[patch powertop svn] don't suggest NO_HZ unless it's possible!
Magnus Fromreide
magfr at lysator.liu.se
Wed Sep 26 22:52:22 PDT 2007
On ons, 2007-09-26 at 22:27 -0700, Arjan van de Ven wrote:
> David Brownell wrote:
> > This patch gets rid of a major annoyance: it stops the "use NO_HZ!"
> > suggestions on x86_64 and other platforms which can't support it.
>
> Hi,
>
> I both agree and disagree with this. x86_64 does support NO_HZ, you
> just need a 2.6.24 kernel or the -hrt patchkit. So I agree the current
> message isn't correct.... but I don't think just making it go away is
> right either; PowerTOP should suggest getting a tickless kernel in
> that case.
>
> >
> > This lets the other messages -- the ones which could actually do some
> > good on this system!! -- be seen. Else, it seems like the impossible
> > NO_HZ suggestion is the only one ever visible.
>
> hmm that would be a bug; in principle the messages should rotate (but
> with a priority bias); it could be the priorities are just off...
Would it be possible to add a command to get to the next suggestion, or
maybe even a way to navigate among the active suggestions.
Even with the rotation it seems you mostly ends up with the wrong
message, so some user control here would be nice.
/MF
More information about the Power
mailing list